Skip to content

Commit

Permalink
[docs] small changes
Browse files Browse the repository at this point in the history
  • Loading branch information
tdixon97 committed Jan 14, 2025
1 parent 887eb72 commit 5678c73
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
8 changes: 6 additions & 2 deletions docs/developer.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,13 @@ $ cmake -DCMAKE_INSTALL_PREFIX=<optional prefix> ..
$ make install
```

```{tip}
:::{warning}
If you want to run the _remage_ tests the cmake flag `-DBUILD_TESTING=ON` is required.
:::

:::{note}
A list of available Make targets can be printed by running `make help`.
```
:::

## Code style

Expand Down
7 changes: 4 additions & 3 deletions tests/confinement/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ set_tests_properties(
confine-gdml-fixture)

# analyse subtraction
add_test(NAME confinment-lar/subtraction COMMAND ${PYTHONPATH} ./test_lar_subtraction.py
test-confine-lar-out.lh5 lar-sub-check.output.pdf)
add_test(NAME confinment-lar/subtraction
COMMAND ${PYTHONPATH} ./test_lar_subtraction.py test-confine-lar-out.lh5
lar-sub-check.output.pdf)

set_tests_properties(confinment-lar/subtraction PROPERTIES LABELS extra FIXTURES_REQUIRED
confine-lar-out-output-fixture)
Expand All @@ -92,7 +93,7 @@ add_test(NAME confinment-lar/intersection-and-subtraction
lar-int-and-sub-check.output.pdf)

set_tests_properties(confinment-lar/intersection-and-subtraction
PROPERTIES LABELS extra FIXTURES_REQUIRED confine-lar-ibn-out-output-fixture)
PROPERTIES LABELS extra FIXTURES_REQUIRED confine-lar-in-out-output-fixture)

# test generic surface sampling methods
add_executable(test-surface-sampler-methods EXCLUDE_FROM_ALL test-surface-sampler-methods.cpp)
Expand Down
3 changes: 2 additions & 1 deletion tests/confinement/test-surface-sampler-methods.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ int RunVis(RMGVertexConfinement::SampleableObject obj, std::string name) {
UImanager->ApplyCommand("/vis/viewer/set/globalLineWidthScale 1.5");
UImanager->ApplyCommand("/vis/viewer/set/upVector 0 0 1");

UImanager->ApplyCommand("/vis/ogl/export surface-sample-bounding-box-" + name + ".output.pdf");
UImanager->ApplyCommand(
"/vis/ogl/export surface-sample-bounding-box-" + name + ".output.pdf");


delete visManager;
Expand Down
2 changes: 1 addition & 1 deletion tests/confinement/test_basic_surface.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def add_local_pos(vertices, pos):
dtype = args.det


with PdfPages(f"simple-solids-surface-{dtype}.output.pdf") as pdf:
with PdfPages(f"confinement.simple-solids-surface-{dtype}.output.pdf") as pdf:
# get positions
pos = reg.physicalVolumeDict[dtype].position.eval()

Expand Down
2 changes: 1 addition & 1 deletion tests/confinement/test_confinment_ge.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,6 @@ def make_plot(vert, hit):


p, sigma = make_plot(vertices, hits)
plt.savefig("confinement-ge.output.pdf")
plt.savefig("relative-ge.output.pdf")

assert sigma < 5

0 comments on commit 5678c73

Please sign in to comment.