Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncertainties for active volume calculation #87

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

fhagemann
Copy link
Contributor

Alternative to #80 (which can be used once https://github.com/legend-exp/legend-detectors/pull/48 is merged and according dummy values are added to legend-testdata).

I am not sure if Measurements can deal with asymmetric errors, so right now I'm estimating the uncertainty as the maximum number quoted as uncertainty in the metadata (pos and neg).

@fhagemann fhagemann marked this pull request as draft December 17, 2024 16:37
@fhagemann fhagemann added the enhancement New feature or request label Dec 17, 2024
@fhagemann fhagemann self-assigned this Dec 17, 2024
@fhagemann fhagemann requested a review from theHenks December 17, 2024 16:38
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.08%. Comparing base (a660e56) to head (769ce11).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   42.08%   42.08%           
=======================================
  Files          26       26           
  Lines        1972     1972           
=======================================
  Hits          830      830           
  Misses       1142     1142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann marked this pull request as ready for review December 27, 2024 11:47
@fhagemann
Copy link
Contributor Author

This implementation will only work if the latest metadata is loaded
(with the FCCD values provided in https://github.com/legend-exp/legend-detectors/pull/48), so make sure to upgrade the detector metadata before using this

@fhagemann
Copy link
Contributor Author

@theHenks

@fhagemann fhagemann merged commit 41eb3c8 into legend-exp:main Jan 24, 2025
10 checks passed
@fhagemann fhagemann deleted the fccd branch January 24, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant