Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Centered the 'Show more' button in Import from other channels #4864

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jayesh9747
Copy link
Contributor

Summary

This PR addresses issue #4838, where the 'Show more' button in the "Import from other channels" section was not centered.

Changes made:

  • Updated the CSS in ContentTreeList.vue to center-align the 'Show more' button using flexbox.
  • Verified manually to ensure proper alignment across different screen sizes and browsers.

Before and After Screenshots:

Before:

image

After:

Screenshot from 2024-12-22 18-43-31

References


Reviewer guidance

To test the changes:

  1. Navigate to the "Import from other channels" section in the application.
  2. Verify that the 'Show more' button is centered as intended.
  3. Test the UI alignment on various screen sizes to ensure responsiveness.

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Code changes are consistent with other components, and manual QA confirm the fix. Thank you @jayesh9747!

@AlexVelezLl AlexVelezLl merged commit a4ff3b6 into learningequality:unstable Jan 3, 2025
14 checks passed
@jayesh9747
Copy link
Contributor Author

@AlexVelezLl i want to contribute more issue realted to backend can you suggest me any issue which i should pickup ?

@MisRob
Copy link
Member

MisRob commented Jan 15, 2025

Hi @jayesh9747, thank you! It's best to keep an eye on 'help wanted' issues - sometimes backend ones appear too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants