BottomBar replaced with BottomToolBar

[cerdo03]

Summary

Description of the change(s) you made

Fixes #2008
I have replaced all occurences of BottomBar with BottomToolBar. Modified the import statements accordingly. Should I delete the BottomBar.vue file? Please review and let me know if my approach is right or do I need to take care of anything else?

---

Reviewer guidance

How can a reviewer test these changes?

Should I delete the BottomBar.vue file?

References

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[cerdo03]

Hi @MisRob,
Please review my PR and let me know if any more changes are required.

[MisRob]

Thanks @cerdo03, I asked my colleagues for review.

Should I delete the BottomBar.vue file

If it's not used from anywhere (which I assume isn't since that's the main task here?) then yes, please

[AllanOXDi]

Thanks @cerdo03 , The changes looks good to me, after the deleting BottomBar.vue file we should be able to merge it.

[cerdo03]

@AllanOXDi I have deleted the BottomBar.vue file. Please review if this is ready to merge.

[marcellamaki]

Hi @cerdo03 - thank you so much for your work here! We are so glad to have your contributions to Studio.

Before merge, please see if you can resolve your linting errors. You can use yarn run lint-frontend:format to see if any can be resolved automatically, or yarn run lint-frontend to see errors. For more information about linting tools, you can refer to the Linting section of the dev docs. Let us know if you have questions.

Once this is complete, will be happy to accept your contribution as it is, but I also wanted to share with you that your PR prompted a small discussion within our team about these two files. In the future, we will begin moving away from using Vuetify, which is the component framework you see in some files where a component is pre-pended with "V", such as VToolbar. Although this was not required in the original issue specification, upon reflection and discussion, we would slightly prefer the BottomBar component over the BottomToolBar component, for this reason, as it will help us with this migration as we get to it.

Since it was not described in the original issue, we will gladly accept your contribution, and I can create a follow-up task for someone on our team to complete. But, if you would be interested in continuing to work on this, switching the solution by replacing BottomToolBar (uses Vuetify) with BottomBar (does not use Vuetify) using the same approach, we would welcome that change. Please let me know if you would like us to proceed with your contribution as-is, or if you'd like to continue working on it, and if you have any additional questions!

Thank you again for your interest in contributing to Studio!

[cerdo03]

@marcellamaki I would love to continue working on this issue. I'll make the desired changes and raise an updated PR soon. Thank you for the feedback.

[rtibbles]

Looks like this work is being finalized in #4359 - so closing this PR in favour of that one.