Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue number 2074 resolved #4350

Merged
merged 4 commits into from
Jan 11, 2024
Merged

issue number 2074 resolved #4350

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99324e9
issue number 2074 resolved
cerdo03 Dec 7, 2023
eb36e5f
changes as suggested by the maintainers
cerdo03 Dec 12, 2023
191d32a
Merge branch 'unstable' of github.com:cerdo03/studio into issues-fix-…
cerdo03 Dec 17, 2023
9bafc01
lint test
cerdo03 Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contentcuration/contentcuration/frontend/shared/views/LanguageDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
},
methods: {
languageText(item) {
return this.$tr('languageItemText', { language: item.native_name, code: item.id });
return this.$tr('languageItemText', { language: item.first_native_name, code: item.id });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cerdo0! It seems like the value of item.first_native_name is undefined. The output now only shows the code of the language in the dropdown.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be something like this could work?
const firstNativeName = item.native_name.split(',')[0].trim()
cc @MisRob?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2074 is a pretty old issue, so yes, it seems first_native_name is obsolete. I don't see it anywhere in the codebase https://github.com/search?q=repo%3Alearningequality%2Fstudio+first_native_name&type=code.

@ozer550 your suggestion makes sense. I'd just suggest confirming that

native_name can be a comma separated list of names

is still a valid remark.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it is! If we see for the code (nv) then it shows comma separated name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MisRob @ozer550 ,
I have made the changes as suggested by you guys. Please review my changes.

},
},
$trs: {
Expand Down