Fix issue created by download_sigil.sh #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronasorman
force-pushed
the
fix-timeout
branch
3 times, most recently
from
19d1b3e to
dc81dc7
Compare
|
Any issues with this PR @bjester? Wanna make sure unstable still isn't broken 😅 |
bjester
requested changes
Dec 12, 2023
.github/workflows/nginxtest.yml
Outdated
| runs-on: ubuntu-latest | ||
| # Map a step output to a job output | ||
| outputs: | ||
| should_skip: ${{ steps.skip_check.outputs.should_skip }} |
There was a problem hiding this comment.
This doesn't appear to be doing anything with should_skip and hence skipping the build if unnecessary
|
@aronasorman I created a new workflow that we needed for building the postgres image with pg-vector. Let me know if you would like me to consolidate yours here with it https://github.com/learningequality/studio/blob/unstable/.github/workflows/containerbuild.yml |
|
Yup works for me! I made a separate file because i want to write more tests in the future. But I don't know when I'll actually get to that. Happy to merge it to your new pg file if it makes more sense. |
added 4 commits
January 31, 2024 10:34
Nginx isn't fully integrated yet. We add it here so we can run a docker build and test that it's working
bjester
approved these changes
Jan 31, 2024
24 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #4336 (comment), We use the wrong arch format (x86-64 vs. amd64, the latter is the one used by the Sigil project).
Also, error out sooner by using
set -eon the script preamble.Update: We now also build the Nginx docker image during PRs and one of the critical branches.