Skip to content

Commit

Permalink
Merge pull request #4661 from AlexVelezLl/fix-copy-resource
Browse files Browse the repository at this point in the history
Fix duplicate nodes
  • Loading branch information
rtibbles authored Aug 20, 2024
2 parents d0b1e54 + fe7cdb5 commit 72d269f
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,12 @@ export const ContentNode = new TreeResource({
return Promise.all([getNode, this.where({ parent: parent.id }, false)]).then(
([node, siblings]) => {
let lft = 1;
siblings = siblings.filter(s => s.id !== id);
// if isCreate is true and target === id, it means it is inserting a node after the
// same node (duplicating it), so we will need this node among the siblings to get
// the right sort order
if (!isCreate || target !== id) {
siblings = siblings.filter(s => s.id !== id);
}
if (siblings.length) {
// If we're creating, we don't need to worry about passing the ID
lft = this.getNewSortOrder(isCreate ? null : id, target, position, siblings);
Expand Down

0 comments on commit 72d269f

Please sign in to comment.