Skip to content

Commit

Permalink
Merge pull request #4672 from marcellamaki/remove-single-resource-label
Browse files Browse the repository at this point in the history
When only one resource is individually selected, do not write '1 resource selected' because it's confusing
  • Loading branch information
rtibbles authored Aug 23, 2024
2 parents 34a940f + d211d79 commit 0a60274
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@submit="handleSave"
@cancel="close"
>
<p data-test="resources-selected-message">
<p v-if="nodeIds.length > 1" data-test="resources-selected-message">
{{ $tr('resourcesSelected', { count: nodeIds.length }) }}
</p>
<template v-if="isMultipleAudience">
Expand Down Expand Up @@ -168,4 +168,4 @@
.modal-subheading {
margin-bottom: 12px;
}
</style>
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@submit="handleSave"
@cancel="close"
>
<p data-test="resources-selected-message">
<p v-if="nodeIds.length > 1" data-test="resources-selected-message">
{{ $tr('resourcesSelected', { count: nodeIds.length }) }}
</p>
<template v-if="isDescendantsUpdatable && isTopicSelected">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
@submit="handleSave"
@cancel="close"
>
<p data-test="resources-selected-message">
<p v-if="nodeIds.length > 1" data-test="resources-selected-message">
{{ $tr('resourcesSelected', { count: nodeIds.length }) }}
</p>
<p v-if="isMultipleNodeLanguages" data-test="different-languages-message">
Expand Down Expand Up @@ -177,4 +177,4 @@
height: 250px;
overflow-y: auto;
}
</style>
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@submit="handleSave"
@cancel="close"
>
<p data-test="resources-selected-message" style="margin-top: 8px;">
<p v-if="nodeIds.length > 1" data-test="resources-selected-message" style="margin-top: 8px;">
{{ $tr('resourcesSelected', { count: nodeIds.length }) }}
</p>
<div class="form-item">
Expand Down Expand Up @@ -327,4 +327,4 @@
}
}
</style>
</style>

0 comments on commit 0a60274

Please sign in to comment.