-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use isAppContext to determine if we're in an embedded WebView… #7663
[WIP] Use isAppContext to determine if we're in an embedded WebView… #7663
Conversation
… Mac, and Android.
…olibri into win_app_check
… dependency issues.
Codecov Report
|
@@ -38,7 +38,7 @@ | |||
|
|||
<script> | |||
|
|||
import { isEmbeddedWebView } from 'kolibri.utils.browserInfo'; | |||
import { isEmbeddedWebView } from 'kolibri.utils.appInfo'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEmbddedWebView
needs to be called as function on line 56 below
Closing this PR as this approach will take more work than anticipated, and given that it is probably better to just focus on switching to |
…on Win, Mac, and Android.
Summary
Fixes learningequality/kolibri-app#68 (comment)
Marking this as WIP until I can get built packages to try out in the apps.
Reviewer guidance
Check that within the app, download buttons do not appear, but that they do appear when run in the browser.
References
…
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)