Fixes assigned lessons and quizzes are not visible to the learner #12992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Learn
AllanOXDi
commented
Jan 9, 2025
| @@ -36,6 +36,12 @@ export default [ | |||
| { | |||
| name: ClassesPageNames.CLASS_ASSIGNMENTS, | |||
| path: '/classes/:classId', | |||
| props: route => { | |||
| const classId = route.params.classId; | |||
There was a problem hiding this comment.
I thought of passing classId as a prop to make it accessible in the component which was not possible with this.$route.params.classId
Build Artifacts
|
rtibbles
reviewed
Jan 9, 2025
| const className = computed(() => (get(classroom) ? get(classroom).name : '')); | ||
| const activeLessons = computed(() => getClassActiveLessons(get(classId))); | ||
| const activeQuizzes = computed(() => getClassActiveQuizzes(get(classId))); | ||
| const activeLessons = computed(() => getClassActiveLessons(get(classId.value))); |
There was a problem hiding this comment.
Shouldn't have to call get and use the .value accessor - only one or the other is needed.
pcenov
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks @AllanOXDi - no issues observed while manually testing.
rtibbles
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes quizes and lessons not being visible to learners
Screen.Recording.2025-01-09.at.18.06.36.mov
Closes #12955
References
#12955
Reviewer guidance