Skip build of all boost modules except boost::mpi #141
Conversation
| @@ -11,7 +11,8 @@ ExternalProject_Add(ppc_boost | |||
| BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/ppc_boost/build" | |||
| INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/ppc_boost/install" | |||
| CONFIGURE_COMMAND "${CMAKE_COMMAND}" -S "${CMAKE_SOURCE_DIR}/3rdparty/boost/" -B "${CMAKE_CURRENT_BINARY_DIR}/ppc_boost/build/" | |||
| -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER} -G${CMAKE_GENERATOR} -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DBOOST_ENABLE_MPI=ON | |||
| -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER} -G${CMAKE_GENERATOR} -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} | |||
| -DBOOST_INCLUDE_LIBRARIES=mpi -DBOOST_ENABLE_MPI=ON | |||
There was a problem hiding this comment.
Potential problem with functions required for the following tasks.
TODO: check
There was a problem hiding this comment.
Just MPI is not enough, but it is hard to limit the scope of necessary functions. I suggest to leave original command line as is
There was a problem hiding this comment.
Also bringing the entire boost library seems like overkill, maybe pull only the boost::mpi with its transitive dependencies?
There was a problem hiding this comment.
Yes, this is going to be implemented, actually. Boost MPI will be extracted and brought as the only 3rdparty boost dependency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 28 28
Lines 593 593
Branches 160 161 +1
=======================================
Hits 575 575
Misses 2 2
Partials 16 16 ☔ View full report in Codecov by Sentry. |
No description provided.