Bump min dart version to 2.17.0 (#53)

* Set min dart to 2.17.0 and flutter to 3.0.0 * Use super paramters * Bump leancode_lint package * Change MultiMessageListener child parameter to not required
leancodepl · Mar 14, 2023 · db2e0e8 · db2e0e8
1 parent 3589c12
commit db2e0e8
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 16 deletions.
diff --git a/.github/workflows/comms-prepare.yaml b/.github/workflows/comms-prepare.yaml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        sdk: [2.16.2, stable, beta]
+        sdk: [2.17.0, stable, beta]
 
     defaults:
       run:

diff --git a/.github/workflows/flutter_comms-prepare.yaml b/.github/workflows/flutter_comms-prepare.yaml
@@ -20,7 +20,7 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - version: 2.10.5
+          - version: 3.0.0
           - channel: stable
           - channel: beta
 

diff --git a/packages/comms/pubspec.yaml b/packages/comms/pubspec.yaml
@@ -4,13 +4,13 @@ version: 0.0.9+1
 homepage: https://github.com/leancodepl/comms
 
 environment:
-  sdk: ">=2.16.0 <3.0.0"
+  sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
   logging: ^1.0.2
   meta: ^1.7.0
   uuid: ^3.0.6
 
 dev_dependencies:
-  leancode_lint: ^1.1.0
+  leancode_lint: ^2.1.0+1
   test: ^1.16.4
diff --git a/packages/flutter_comms/lib/src/listener_bloc.dart b/packages/flutter_comms/lib/src/listener_bloc.dart
@@ -16,7 +16,7 @@ import 'package:meta/meta.dart' show mustCallSuper;
 /// which handles calling [listen] and [cancel] automatically.
 abstract class ListenerBloc<Event, State, Message> extends Bloc<Event, State>
     with Listener<Message> {
-  ListenerBloc(State initialState) : super(initialState) {
+  ListenerBloc(super.initialState) {
     super.listen();
   }
 

diff --git a/packages/flutter_comms/lib/src/listener_cubit.dart b/packages/flutter_comms/lib/src/listener_cubit.dart
@@ -18,7 +18,7 @@ import 'package:meta/meta.dart' show mustCallSuper;
 /// which handles calling [listen] and [cancel] automatically.
 abstract class ListenerCubit<State, Message> extends Cubit<State>
     with Listener<Message> {
-  ListenerCubit(State initialState) : super(initialState) {
+  ListenerCubit(super.initialState) {
     super.listen();
   }
 

diff --git a/packages/flutter_comms/lib/src/widgets/message_listener.dart b/packages/flutter_comms/lib/src/widgets/message_listener.dart
@@ -20,11 +20,11 @@ mixin MessageListenerSingleChildWidget on SingleChildWidget {}
 class MessageListener<Message> extends SingleChildStatefulWidget
     with MessageListenerSingleChildWidget {
   const MessageListener({
-    Key? key,
+    super.key,
     required this.onMessage,
     this.onInitialMessage,
-    Widget? child,
-  }) : super(key: key, child: child);
+    super.child,
+  });
 
   final OnMessage<Message> onMessage;
   final OnMessage<Message>? onInitialMessage;

diff --git a/packages/flutter_comms/lib/src/widgets/multi_message_listener.dart b/packages/flutter_comms/lib/src/widgets/multi_message_listener.dart
@@ -1,4 +1,3 @@
-import 'package:flutter/material.dart';
 import 'package:flutter_comms/src/widgets/message_listener.dart';
 import 'package:nested/nested.dart';
 
@@ -24,8 +23,8 @@ import 'package:nested/nested.dart';
 ///
 class MultiMessageListener extends Nested {
   MultiMessageListener({
-    Key? key,
+    super.key,
     required List<MessageListenerSingleChildWidget> listeners,
-    required Widget child,
-  }) : super(key: key, children: listeners, child: child);
+    super.child,
+  }) : super(children: listeners);
 }
diff --git a/packages/flutter_comms/pubspec.yaml b/packages/flutter_comms/pubspec.yaml
@@ -4,8 +4,8 @@ version: 0.0.6+2
 homepage: https://github.com/leancodepl/comms
 
 environment:
-  sdk: ">=2.16.0 <3.0.0"
-  flutter: ">=2.17.0 <4.0.0"
+  sdk: ">=2.17.0 <3.0.0"
+  flutter: ">=3.0.0 <4.0.0"
 
 dependencies:
   bloc: ^8.1.0
@@ -21,4 +21,4 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  leancode_lint: ^2.1.0
+  leancode_lint: ^2.1.0+1