Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rubocop and tests running locally #122

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Get rubocop and tests running locally #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ require:
- rubocop-rake
- rubocop-rspec
- rubocop-capybara
- rubocop-factory_bot
- rubocop-rspec_rails

AllCops:
TargetRubyVersion: 2.5
Expand Down Expand Up @@ -491,9 +493,6 @@ RSpec/NestedGroups:
RSpec/AnyInstance:
Enabled: false

RSpec/FilePath:
Enabled: false

RSpec/LeakyConstantDeclaration:
Enabled: false

Expand Down Expand Up @@ -527,6 +526,9 @@ RSpec/SubjectDeclaration:
RSpec/VerifiedDoubleReference:
Enabled: true

RSpec/ExpectInLet:
Enabled: false

RSpec/Rails/AvoidSetupHook:
Enabled: true

Expand Down
5 changes: 4 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@ gem 'redis-client'
gem 'resque'
gem 'rspec-rails'
gem 'rubocop'
gem 'rubocop-capybara'
gem 'rubocop-factory_bot'
gem 'rubocop-rake'
gem 'rubocop-rspec'
gem 'rubocop-rspec_rails'
gem 'sidekiq', '>= 3.0'
gem 'spork'
gem 'sqlite3', '>= 1.3'
gem 'sqlite3', '~> 1.3'
gem 'timecop'

gemspec
18 changes: 18 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,24 @@ nicolas@desktop:$ echo $?
2
```

## Development
In order to work on development on the gem itself

### Installing the gems
Use the [appraisal gem](https://github.com/thoughtbot/appraisal) to install the bundles for different rails versions:

```bash
appraisal clean
appraisal generate
appraisal install
```

### Running the tests
Use appraisal to run the tests using rake
```bash
appraisal rake
```

## License

The MIT License (MIT)
Expand Down
5 changes: 4 additions & 1 deletion gemfiles/rails_6.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@ gem 'redis-client'
gem 'resque'
gem 'rspec-rails'
gem 'rubocop'
gem 'rubocop-capybara'
gem 'rubocop-factory_bot'
gem 'rubocop-rake'
gem 'rubocop-rspec'
gem 'rubocop-rspec_rails'
gem 'sidekiq', '>= 3.0'
gem 'spork'
gem 'sqlite3', '>= 1.3'
gem 'sqlite3', '~> 1.3'
gem 'timecop'

gemspec path: '../'
5 changes: 4 additions & 1 deletion gemfiles/rails_7.1_.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@ gem 'redis-client'
gem 'resque'
gem 'rspec-rails'
gem 'rubocop'
gem 'rubocop-capybara'
gem 'rubocop-factory_bot'
gem 'rubocop-rake'
gem 'rubocop-rspec'
gem 'rubocop-rspec_rails'
gem 'sidekiq', '>= 3.0'
gem 'spork'
gem 'sqlite3', '>= 1.3'
gem 'sqlite3', '~> 1.3'
gem 'timecop'

gemspec path: '../'
Loading