Fix lint warnings

lbeder · Nov 11, 2024 · 452a330 · 452a330
1 parent df42de7
commit 452a330
Show file tree

Hide file tree

Showing 9 changed files with 77 additions and 14 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.1.4', '3.2.3', '3.3.0']
+        ruby: ['3.1.6', '3.2.5', '3.3.6']
 
     name: Ruby ${{ matrix.ruby }}
     steps:

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -397,6 +397,21 @@ Lint/MixedCaseRange:
 Lint/RedundantRegexpQuantifiers:
   Enabled: true
 
+Lint/DuplicateSetElement:
+  Enabled: true
+
+Lint/ItWithoutArgumentsInBlock:
+  Enabled: true
+
+Lint/LiteralAssignmentInCondition:
+  Enabled: true
+
+Lint/UnescapedBracketInRegexp:
+  Enabled: true
+
+Lint/UselessNumericOperation:
+  Enabled: true
+
 Naming/BlockForwarding:
   Enabled: true
 
@@ -409,6 +424,9 @@ Gemspec/DeprecatedAttributeAssignment:
 Gemspec/DevelopmentDependencies:
   Enabled: true
 
+Gemspec/AddRuntimeDependency:
+  Enabled: true
+
 Layout/LineContinuationLeadingSpace:
   Enabled: true
 
@@ -478,6 +496,39 @@ Style/ReturnNilInPredicateMethodDefinition:
 Style/YAMLFileRead:
   Enabled: true
 
+Style/AmbiguousEndlessMethodDefinition:
+  Enabled: true
+
+Style/BitwisePredicate:
+  Enabled: true
+
+Style/CombinableDefined:
+  Enabled: true
+
+Style/KeywordArgumentsMerging:
+  Enabled: true
+
+Style/MapIntoArray:
+  Enabled: true
+
+Style/RedundantInterpolationUnfreeze:
+  Enabled: true
+
+Style/SafeNavigationChainLength:
+  Enabled: true
+
+Style/SendWithLiteralMethodName:
+  Enabled: true
+
+Style/SingleLineDoEndBlock:
+  Enabled: true
+
+Style/SuperArguments:
+  Enabled: true
+
+Style/SuperWithArgsParentheses:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
@@ -529,13 +580,13 @@ RSpec/VerifiedDoubleReference:
 RSpec/ExpectInLet:
   Enabled: false
 
-RSpec/Rails/AvoidSetupHook:
+RSpecRails/AvoidSetupHook:
   Enabled: true
 
-RSpec/Rails/HaveHttpStatus:
+RSpecRails/HaveHttpStatus:
   Enabled: true
 
-RSpec/Rails/InferredSpecType:
+RSpecRails/InferredSpecType:
   Enabled: false
 
 RSpec/DuplicatedMetadata:
@@ -550,10 +601,10 @@ RSpec/RedundantAround:
 RSpec/SkipBlockInsideExample:
   Enabled: true
 
-RSpec/Rails/MinitestAssertions:
+RSpecRails/MinitestAssertions:
   Enabled: true
 
-RSpec/Rails/TravelAround:
+RSpecRails/TravelAround:
   Enabled: true
 
 RSpec/BeEmpty:
@@ -586,7 +637,10 @@ RSpec/SpecFilePathFormat:
 RSpec/SpecFilePathSuffix:
   Enabled: true
 
-RSpec/Rails/NegationBeValid:
+RSpecRails/NegationBeValid:
+  Enabled: true
+
+RSpec/StringAsInstanceDoubleConstant:
   Enabled: true
 
 Capybara/NegationMatcher:
@@ -613,6 +667,9 @@ Capybara/RSpec/HaveSelector:
 Capybara/RSpec/PredicateMatcher:
   Enabled: true
 
+Capybara/RedundantWithinFind:
+  Enabled: true
+
 FactoryBot/ConsistentParenthesesStyle:
   Enabled: true
 
@@ -633,3 +690,9 @@ FactoryBot/IdSequence:
 
 FactoryBot/RedundantFactoryOption:
   Enabled: true
+
+FactoryBot/CreateList:
+  Enabled: true
+
+FactoryBot/ExcessiveCreateList:
+  Enabled: true
diff --git a/Gemfile b/Gemfile
@@ -21,7 +21,7 @@ gem 'rubocop-rspec'
 gem 'rubocop-rspec_rails'
 gem 'sidekiq', '>= 3.0'
 gem 'spork'
-gem 'sqlite3', '~> 1.3'
+gem 'sqlite3', '>= 2.1'
 gem 'timecop'
 gem 'webmock'
 

diff --git a/gemfiles/rails_6.1.gemfile b/gemfiles/rails_6.1.gemfile
@@ -20,7 +20,7 @@ gem 'rubocop'
 gem 'rubocop-capybara'
 gem 'rubocop-factory_bot'
 gem 'rubocop-rake'
-gem 'rubocop-rspec'
+gem 'rubocop-rspec's
 gem 'rubocop-rspec_rails'
 gem 'sidekiq', '>= 3.0'
 gem 'spork'

diff --git a/lib/health_monitor/providers/delayed_job.rb b/lib/health_monitor/providers/delayed_job.rb
@@ -14,7 +14,7 @@ class Configuration < Base::Configuration
         attr_accessor :queue_size
 
         def initialize(provider)
-          super(provider)
+          super
 
           @queue_size = DEFAULT_QUEUES_SIZE
         end

diff --git a/lib/health_monitor/providers/file_absence.rb b/lib/health_monitor/providers/file_absence.rb
@@ -12,7 +12,7 @@ class Configuration < Base::Configuration
         attr_accessor :filename
 
         def initialize(provider)
-          super(provider)
+          super
 
           @filename = DEFAULT_FILENAME
         end

diff --git a/lib/health_monitor/providers/redis.rb b/lib/health_monitor/providers/redis.rb
@@ -15,7 +15,7 @@ class Configuration < Base::Configuration
         attr_accessor :url, :connection, :max_used_memory
 
         def initialize(provider)
-          super(provider)
+          super
 
           @url = DEFAULT_URL
         end

diff --git a/lib/health_monitor/providers/sidekiq.rb b/lib/health_monitor/providers/sidekiq.rb
@@ -18,7 +18,7 @@ class Configuration < Base::Configuration
         attr_reader :queues
 
         def initialize(provider)
-          super(provider)
+          super
 
           @maximum_amount_of_retries = DEFAULT_RETRY_CHECK
 

diff --git a/lib/health_monitor/providers/solr.rb b/lib/health_monitor/providers/solr.rb
@@ -13,7 +13,7 @@ class Configuration < Base::Configuration
         attr_accessor :url, :collection
 
         def initialize(provider)
-          super(provider)
+          super
 
           @url = DEFAULT_URL
           @collection = DEFAULT_COLLECTION