feat: support testing TLS options with two new capabilities #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
12d5951 to
6b07eab
Compare
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
bd93b7f to
fcb1070
Compare
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
4ea74a3 to
cb4f3a4
Compare
cwaldren-ld
commented
May 8, 2024
| "github.com/launchdarkly/sdk-test-harness/v2/framework" | ||
| ) | ||
|
|
||
| // TestServiceInfo is status information returned by the test service from the initial status query. |
There was a problem hiding this comment.
This has been refactored out into a new single-purpose serviceinfo package because I needed to introduce a circular dependency.
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
a094225 to
63597b8
Compare
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
3c45d64 to
af432ce
Compare
cwaldren-ld
commented
May 8, 2024
cwaldren-ld
changed the title
cwaldren-ld
commented
May 9, 2024
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
db6106c to
bc177d3
Compare
cwaldren-ld
force-pushed
the
cw/sc-239174/tls
branch
from
bc177d3 to
c9f134a
Compare
tanderson-ld
reviewed
May 9, 2024
tanderson-ld
approved these changes
May 10, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
May 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.13.0](v2.12.0...v2.13.0) (2024-05-10) ### Features * support testing TLS options with two new capabilities ([#208](#208)) ([6a90eb0](6a90eb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we haven't tested SDKs using https protocol in contract tests.
This is usually not a problem since each language has some http library that is probably well tested. But, it's a bit more manual in some languages, including C++.
This PR adds two new capabilities. The first is
tls:skip-verify-peer. If provided, then the SDK under test will receive:skipVerifyPeer bool: whether or not the peer should be verifiedThis allows for tests of streaming/polling/events under the https protocol using a self-signed certificate.
The second is
tls:verify-peer. If provided, the harness will make the SDK under test connect using https and present a self-signed certificate. This should be rejected by the SDK.In this initial PR, there is no support for configuring a CA. When I add that support, it will be a 3rd capability that interacts with the other two.