Skip to content

Commit

Permalink
more docs
Browse files Browse the repository at this point in the history
  • Loading branch information
cwaldren-ld committed Apr 2, 2024
1 parent 3357e7b commit 8e0f475
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion sdktests/server_side_hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,9 @@ func beforeEvaluationDataPropagatesToAfterMigration(t *ldtest.T) {
})
}

// This test is meant to check Requirement HOOKS:1.3.7.
// This test is meant to check Requirement HOOKS:1.3.7:
// The client MUST handle exceptions which are thrown (or errors returned, if idiomatic for the language)
// during the execution of a stage or handler allowing operations to complete unaffected.
func errorInBeforeStageDoesNotAffectAfterStage(t *ldtest.T) {

Check failure on line 277 in sdktests/server_side_hooks.go

View workflow job for this annotation

GitHub Actions / build-and-test

unnecessary leading newline (whitespace)

const numHooks = 100 // why not?
Expand Down Expand Up @@ -302,6 +304,8 @@ func errorInBeforeStageDoesNotAffectAfterStage(t *ldtest.T) {
DefaultValue: ldvalue.Bool(false),
})

// Since we shouldn't receive any beforeEvaluation calls, the number of calls to expect is simply
// the number of hooks configured.
const numAfterCalls = numHooks
calls := hooks.ExpectSingleCallForEachHook(t, names, numAfterCalls)

Expand Down

0 comments on commit 8e0f475

Please sign in to comment.