feat: Add ability to provide dynamic query parameters #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Dec 18, 2024
stream.go
Outdated
| @@ -231,6 +237,9 @@ func (stream *Stream) connect() (io.ReadCloser, error) { | |||
| stream.req.Header.Set("Last-Event-ID", stream.lastEventID) | |||
| } | |||
| req := *stream.req | |||
| if stream.queryParamsFunc != nil { | |||
| req.URL.RawQuery = (*stream.queryParamsFunc)().Encode() | |||
There was a problem hiding this comment.
Should this be a merge? Or do we want replacement behavior?
There was a problem hiding this comment.
I guess we need replacement to be able to remove a parameter.
There was a problem hiding this comment.
Updated so that the previously defined query parameters are sent along on subsequent requests.
kinyoklion
approved these changes
Dec 19, 2024
keelerm84
pushed a commit
that referenced
this pull request
Dec 19, 2024
🤖 I have created a release *beep* *boop* --- ## [1.8.0](v1.7.1...v1.8.0) (2024-12-19) ### Features * Add ability to provide dynamic query parameters ([#44](#44)) ([efc5d86](efc5d86)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.