-
Notifications
You must be signed in to change notification settings - Fork 13
Minor changes #14
base: master
Are you sure you want to change the base?
Minor changes #14
Conversation
*GetTorrent() now returns a single Torrent object *GetProps() now return a single Props object +GetList(bool) now has a optional parameter to fetch all props along with torrents +Added TorrentNotFoundException -Had to make changes to UnitTest, but cant test it since i dont have that installed.
Now i noticed why, you added an enum to props in the meantime, you can just leave your props and parsesr |
I used squash and merge button. It's why you see only one commit until instead of many |
You should rebase your branch on master |
Well, for now you can discard those two files and merge utorrentclientapi, units and new exception... |
But I'm not sure to want this changes. For return type, you will completely hide the api error message/code that you should find in the Response object. Theses contract changes will break compatibility with existing projects. But I have to admit that I did this project a long time ago, and it's look really weird to me now on many aspects. |
I noticed that you had 2 methods doing the exact same things, errors could be handled as an exception, but thats true, it will break apps on update. |
*GetTorrent() now returns a single Torrent object
*GetProps() now return a single Props object
+GetList(bool) now has a optional parameter to fetch all props along with torrents
+Added TorrentNotFoundException
-Had to make changes to UnitTest, but cant test it since i dont have that installed.
Also, why is GitHub behaving as if the first merge never happened?