Skip to content

Commit

Permalink
late review by Chris
Browse files Browse the repository at this point in the history
  • Loading branch information
FrankMittelbach committed Jan 3, 2025
1 parent 7267000 commit 103347b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
9 changes: 5 additions & 4 deletions base/doc/ltnews41.tex
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
% \iffalse meta-comment
%
% Copyright 2024
% Copyright 2024-2025
% The LaTeX Project and any individual authors listed elsewhere
% in this file.
%
Expand Down Expand Up @@ -411,6 +411,7 @@ \subsection{Prevent \texttt{cmd} hook from defining an undefined command}
\section{Changes to packages in the \pkg{graphics} category}

\subsection{More accessibility keys in \pkg{graphicx}}

The \cs{includegraphics} command now accepts \verb|actualtext| and
\verb|artifact| keys, which by default do nothing but are used by the
tagging code to provide an ActualText string and a boolean flag that the
Expand All @@ -437,16 +438,16 @@ \subsection{\pkg{multicol}:\ Full support for extended marks}
\subsection{\pkg{array}:\ Improve preamble setup code for \texttt{p} and friends}

While the preamble of a \env{tabular} or \env{array} is being built
the arguments to \texttt{p}, \texttt{m}, or \texttt{b} columns were
expanded several times. That is normally harmless because that
the arguments to \texttt{p}, \texttt{m}, or \texttt{b} columns
expanded several times. This is normally harmless because that
argument contains usually just a dimension. However, in a case like
\verb=p{\fpeval{15}pt}= this resulted in an error, because \cs{fpeval}
was expanded a few times, but not often enough to result in a single
number. This has now been corrected and the argument is not expanded
at all to allow for such edge cases as well as the extension available
with the \pkg{calc} package, such as \verb=p{\widthof{AAAAAA}}= (the
latter was possible before but needed to be taken into account while
the correction was implemented.
the correction was implemented).
%
\githubissue{1585}

Expand Down
16 changes: 8 additions & 8 deletions required/tools/array.dtx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
% \begin{macrocode}
%<+package>\NeedsTeXFormat{LaTeX2e}[2024/06/01]
%<+package>\ProvidesPackage{array}
%<+package> [2024/12/20 v2.6h Tabular extension package (FMi)]
%<+package> [2025/01/03 v2.6h Tabular extension package (FMi)]
%
% \fi
%
Expand Down Expand Up @@ -2288,10 +2288,10 @@ Bug reports can be opened (category \texttt{#1}) at\\%
% \end{macrocode}
%
% \changes{v2.6h}{2024/12/17}{New \cs{@startpbox@action} to do the real work
% after preamble was built (gh/1585)}
% Starting with 2.6h \cs{@startpbox} is only used during the
% built-up of the preamble changing there to \cs{@startpbox@action}
% To do the real work. For an explanation of this code see
% after the preamble is built (gh/1585)}
% Starting with 2.6h, \cs{@startpbox} is used only during the
% built-up of the preamble and then changed to \cs{@startpbox@action}
% which does the real work. For an explanation of this code see
% the documentation in \cs{@mkpream}. We keep the \cs{@startpbox}
% definition on top-level in case there are tabular packages that
% built the preamble differently and expect that it contains
Expand Down Expand Up @@ -3296,19 +3296,19 @@ Bug reports can be opened (category \texttt{#1}) at\\%
% simple length expression, but with the calc package involved it
% could break under an "\edef" operation, which is how the preamble
% is constructed. We now make use of "\unexpanded" here to prevent that. The
% "\expandafter" gymnastics is necessary to expand the "#1" exactly
% "\expandafter" gymnastics are necessary to expand the "#1" exactly
% once (since it will get "\@nextchar" as its value and need its
% content). However, once added to the preamble, no further
% expansion should happen if the preamble is extended. Therefore we
% change from \cs{@startpbox} to \cs{@startpbox@action}. The latter
% then has a trivial definition and expands (including its
% argument) to itself while the preamble is being built. Outside of this
% preamble built-up \cs{@startpbox@action} then does the actual work.
% preamble build up \cs{@startpbox@action} does the actual work.
%
% \changes{v2.4j}{2018/11/13}{Do not expand argument of
% \cs{@startpbox} while building the tabular preamble (sx/459285)}
% \changes{v2.6h}{2024/12/17}{Expand argument of \cs{@startpbox}
% exactly once while the preamble is built and use
% exactly once while the preamble is being built, and use
% \cs{@startpbox@action} later to do the real work (gh/1585)}
% \begin{macrocode}
\def\@startpbox##1{\unexpanded\expandafter{\expandafter
Expand Down

0 comments on commit 103347b

Please sign in to comment.