Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyproject.toml #12

Merged
merged 1 commit into from
Sep 14, 2024
Merged

add pyproject.toml #12

merged 1 commit into from
Sep 14, 2024

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented Sep 14, 2024

move content of setup.py to pyproject.toml

lassoan
lassoan approved these changes Sep 14, 2024
View reviewed changes
Copy link
Owner

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good to me. Was there any specific reason for the update or just in general to modernize the packaging?

@dyollb
Copy link
Contributor Author

dyollb commented Sep 14, 2024 •
edited
Loading

Not really. I was looking at the dependencies and OCD got hold of me.

It is generally recommended to put metadata in a pyproject.toml (or setup.cfg), but setuptools hasn't deprecated setup.py.
Added benefit: you don't need to parse the _version.py file to get the __version__ (or the README).

@lassoan lassoan merged commit cc77bbe into lassoan:main Sep 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyollb @lassoan