Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Elk 3 switch license #68

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 12, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has the SPDX header SPDX-License-Identifier: $(LICENSE_CODE)
  5. Branch follows the naming format (elk-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #ISSUE-NUMBER

@elfenpiff elfenpiff requested a review from elBoberido December 12, 2023 21:09
@elfenpiff elfenpiff force-pushed the elk-3-switch-license branch from 8b9ce83 to 3c856ff Compare December 12, 2023 21:13
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #68 (3c856ff) into main (346ba62) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   77.88%   77.88%           
=======================================
  Files         172      172           
  Lines       19059    19059           
=======================================
  Hits        14845    14845           
  Misses       4214     4214           
Files Coverage Δ
elkodon/src/config.rs 66.32% <ø> (ø)
elkodon/src/elk.rs 0.00% <ø> (ø)
elkodon/src/message.rs 0.00% <ø> (ø)
elkodon/src/port/details/publisher_connections.rs 87.01% <ø> (ø)
elkodon/src/port/details/subscriber_connections.rs 94.73% <ø> (ø)
elkodon/src/port/event_id.rs 100.00% <ø> (ø)
elkodon/src/port/listener.rs 55.40% <ø> (ø)
elkodon/src/port/mod.rs 0.00% <ø> (ø)
elkodon/src/port/notifier.rs 80.46% <ø> (ø)
elkodon/src/port/port_identifiers.rs 88.88% <ø> (ø)
... and 149 more

... and 13 files with indirect coverage changes

scripts/copyright_header.txt Show resolved Hide resolved
scripts/set_license_header.sh Show resolved Hide resolved
@elfenpiff elfenpiff merged commit 4dd1a49 into larry-robotics:main Dec 12, 2023
16 of 19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants