Code

Code review#2

Code

Open

jgonggrijp wants to merge 11 commits intolark-parser:masterlark-parser/Lark.js:masterfrom jgonggrijp:code-reviewjgonggrijp/Lark.js:code-reviewCopy head branch name to clipboard

+96-108

Commits

Commits on Aug 6, 2021

• Consistently use var

  Show description for d8c1dab
  jgonggrijp

  committed
  d8c1dab

  Copy full SHA for d8c1dab

• Don't forget the semicolons

  Show description for 6d9fb6f
  jgonggrijp

  committed
  6d9fb6f

  Copy full SHA for 6d9fb6f

• Be judicious with blank lines

  Show description for 6a7d151
  jgonggrijp

  committed
  6a7d151

  Copy full SHA for 6a7d151

• Docstrings

  Show description for 0b7407b
  jgonggrijp

  committed
  0b7407b

  Copy full SHA for 0b7407b

• Indentation

  Show description for cc703bc
  jgonggrijp

  committed
  cc703bc

  Copy full SHA for cc703bc

• "Polyfill"

  Show description for 1348cb0
  jgonggrijp

  committed
  1348cb0

  Copy full SHA for 1348cb0

• Use speaking names

  Show description for 2b3000f
  jgonggrijp

  committed
  2b3000f

  Copy full SHA for 2b3000f

• Generator functions

  Show description for 5f7493d
  jgonggrijp

  committed
  5f7493d

  Copy full SHA for 5f7493d

• Functional style with Underscore

  Show description for ffe690c
  jgonggrijp

  committed
  ffe690c

  Copy full SHA for ffe690c

• Remove trailing spaces

  Show description for 073fb4e
  jgonggrijp

  committed
  073fb4e

  Copy full SHA for 073fb4e

• Whitespace around comment blocks

  Show description for 586aa7c
  jgonggrijp

  committed
  586aa7c

  Copy full SHA for 586aa7c