Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option to configure remaining middlware #523

Conversation

bedus-creation
Copy link

Thank you for the excellent package.

This pull request introduces a feature to customize middleware configuration for Illuminate\Session\Middleware\StartSession::class and Illuminate\Foundation\Http\Middleware\ValidateCsrfToken::class.

I understand that while this middleware can be configured using Laravel's documentation, it appears to be only possible for the web group and not for the api group, as these middleware directly applies from EnsureFrontendRequestsAreStateful,

@bedus-creation bedus-creation force-pushed the add-config-option-to-configure-middleware branch from c70007a to 9e907da Compare June 16, 2024 11:23
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants