Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from setup.py to setup.cfg #446

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mcepl
Copy link
Contributor

@mcepl mcepl commented Jan 22, 2025

This is very conservative option, which should work on all normal (and even less than normal) Python platforms. However, I found declarative syntax to be much more pleasing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (c39dd07) to head (1bcf288).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   91.27%   91.32%   +0.05%     
==========================================
  Files           1        1              
  Lines         172      173       +1     
  Branches       22       22              
==========================================
+ Hits          157      158       +1     
  Misses         10       10              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcepl mcepl force-pushed the setup_cfg branch 2 times, most recently from 203604e to 8fde872 Compare January 22, 2025 19:35
Copy link
Owner

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for modernizing this. Looks fine apart from the manually declared version as noted inline. Either the semantic-release infrastructure needs to be changed to update the version, or we need to find some other way to get around this.

passgithelper.py Show resolved Hide resolved
@mcepl mcepl force-pushed the setup_cfg branch 3 times, most recently from d3a9a82 to 99b1663 Compare January 26, 2025 00:37
Copy link
Owner

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. Looks fine now. The only thing we have to think about is the commit history. Let's squash everything down into a single commit like feat(build): switch to.... No need to preserve history about applied isort calls.

This is very conservative option, which should work on all normal
(and even less than normal) Python platforms. However, I found
declarative syntax to be much more pleasing.

Also update .releaserc.json to update version number in the right file.
Copy link
Owner

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work and for updating the PR quickly!

@languitar languitar merged commit 6a893bd into languitar:main Jan 27, 2025
10 checks passed
@renovate-releases
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants