-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from setup.py to setup.cfg #446
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 91.27% 91.32% +0.05%
==========================================
Files 1 1
Lines 172 173 +1
Branches 22 22
==========================================
+ Hits 157 158 +1
Misses 10 10
Partials 5 5 ☔ View full report in Codecov by Sentry. |
203604e
to
8fde872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for modernizing this. Looks fine apart from the manually declared version as noted inline. Either the semantic-release infrastructure needs to be changed to update the version, or we need to find some other way to get around this.
d3a9a82
to
99b1663
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. Looks fine now. The only thing we have to think about is the commit history. Let's squash everything down into a single commit like feat(build): switch to...
. No need to preserve history about applied isort calls.
This is very conservative option, which should work on all normal (and even less than normal) Python platforms. However, I found declarative syntax to be much more pleasing. Also update .releaserc.json to update version number in the right file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work and for updating the PR quickly!
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is very conservative option, which should work on all normal (and even less than normal) Python platforms. However, I found declarative syntax to be much more pleasing.