Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pg vector index #12338

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: add pg vector index #12338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5712796
feat: add pg vector index
Jan 3, 2025
0c95904
fix: add explictly options
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion api/core/rag/datasource/vdb/pgvector/pgvector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ def validate_config(cls, values: dict) -> dict:
) using heap;
"""

SQL_CREATE_INDEX = """
CREATE INDEX IF NOT EXISTS embedding_cosine_v1_idx ON {table_name}
USING hnsw (embedding vector_cosine_ops) WITH (m = 16, ef_construction = 64);
"""


class PGVector(BaseVector):
def __init__(self, collection_name: str, config: PGVectorConfig):
Expand Down Expand Up @@ -200,7 +205,10 @@ def _create_collection(self, dimension: int):
with self._get_cursor() as cur:
cur.execute("CREATE EXTENSION IF NOT EXISTS vector")
cur.execute(SQL_CREATE_TABLE.format(table_name=self.table_name, dimension=dimension))
# TODO: create index https://github.com/pgvector/pgvector?tab=readme-ov-file#indexing
# PG hnsw index only support 2000 dimension or less
# ref: https://github.com/pgvector/pgvector?tab=readme-ov-file#indexing
if dimension <= 2000:
cur.execute(SQL_CREATE_INDEX.format(table_name=self.table_name))
JohnJyong marked this conversation as resolved.
Show resolved Hide resolved
redis_client.set(collection_exist_cache_key, 1, ex=3600)


Expand Down
Loading