fix: use go backend instead of python backend for example functions #1488
+832
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Feb 5, 2025
| @@ -10,7 +10,7 @@ import { | |||
| Example, | |||
| ExampleCreate, | |||
| ExampleUpdate, | |||
| ExampleUpdateWithId, | |||
There was a problem hiding this comment.
Just checking - was this exported publicly?
Also good to preserve naming scheme:
ExampleUpdateWithoutId
jacoblee93
reviewed
Feb 5, 2025
| preparedCreate.attachments !== undefined | ||
| ) { | ||
| allAttachments[preparedCreate.id] = preparedCreate.attachments; | ||
| let preparedCreateParams = |
There was a problem hiding this comment.
Is this equivalent to what was there before?
If so, why change?
jacoblee93
reviewed
Feb 5, 2025
| @@ -2676,113 +2697,164 @@ export class Client implements LangSmithTracingClientInterface { | |||
| return result["examples"] as ExampleSearch[]; | |||
| } | |||
|
|
|||
| public async createExample(update: ExampleCreate): Promise<Example>; | |||
jacoblee93
reviewed
Feb 5, 2025
| await raiseForStatus(response, "create example"); | ||
| const result = await response.json(); | ||
| return result as Example; | ||
| return example; | ||
| } | ||
|
|
||
| public async createExamples(props: { |
There was a problem hiding this comment.
This one should be an overload:
public async createExamples(props: Example[]);
public async createExamples(props: ...<current signature>)
|
deprecate the old signatures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.