update evaluation tutorial #614
Merged
+198
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
baskaryan
reviewed
Jan 9, 2025
| def evaluate_length(run: Run, example: Example) -> dict: | ||
| prediction = run.outputs.get("output") or "" | ||
| required = example.outputs.get("answer") or "" | ||
| def evaluate_length(outputs: dict, reference_outputs: dict) -> dict: |
There was a problem hiding this comment.
could we just call this something like is_concise() and return the bool directly
There was a problem hiding this comment.
yeah going to call it "length" to match the key
baskaryan
reviewed
Jan 14, 2025
Comment on lines
207
to
215
| # Note: If your system is async, you can use the asynchronous `aevaluate` function | ||
| # import asyncio | ||
| # from langsmith import aevaluate | ||
| # | ||
| # experiment_results = asyncio.run(aevaluate( | ||
| # experiment_results = asyncio.run(client.aevaluate( | ||
| # my_async_langsmith_app, # Your AI system | ||
| # data=dataset_name, # The data to predict and grade over | ||
| # evaluators=[evaluate_length, qa_evaluator], # The evaluators to score the results | ||
| # evaluators=[length, correctness], # The evaluators to score the results | ||
| # experiment_prefix="openai-3.5", # A prefix for your experiment names to easily identify them |
There was a problem hiding this comment.
can we delete this comment? dont think its needed in tutorial
There was a problem hiding this comment.
deleted, but would it be valuable to add a note about async compatibility somewhere? wouldn't want people turned away because they think we only do sync stuff.
Co-authored-by: Bagatur <[email protected]>
baskaryan
approved these changes
Jan 16, 2025
isahers1
commented
Jan 16, 2025
Comment on lines
+158
to
+159
| def concision(outputs: dict, reference_outputs: dict) -> bool: | ||
| return int(len(outputs["response"]) < 2 * len(reference_outputs["answer"])) |
There was a problem hiding this comment.
The screenshots all say length so we would need to retake all of them if we want to use concision as the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.