Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langchain redis/release 0.0.4 #12

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

bsbodden
Copy link
Collaborator

@bsbodden bsbodden commented Sep 6, 2024

  • Changes param name for Redis PY client to redis_client consistently in all classes (it was redis in some classes)
  • Adds extra tests for using classes with a Redis PY client
  • Bumps the version to 0.0.4

@bsbodden bsbodden self-assigned this Sep 6, 2024
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- let's make sure docs are also reflective of this change if we have examples that show the other keyword. Alternatively could use kwargs to make it backwards compatable with a warning msg or something

@bsbodden bsbodden merged commit 805b9a2 into langchain-ai:main Sep 6, 2024
12 checks passed
@bsbodden bsbodden deleted the langchain-redis/release-0.0.4 branch September 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants