-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated nginx Versions #63
Conversation
* Added nginx version 1.27 * Updated other bitnami versions * Minor improvements to curl commands
❌ Deploy Preview for lando-nginx failed. Why did it fail? →
|
@reynoldsalec how do I add you as a reviewer? I feel like I might not have permissions to add you. |
Probably missing write permissions, I added you to the repo @lefte. These failing tests are weird...they're supposed to fail (there is no https), but for some reason the error processing isn't working correctly. Definitely not related to anything you did AFAIK. |
It's failing at |
Makes sense, that was my thought as well, I'll make some changes to expect the right message result. |
* Parse the exit code inside of the Leia test container
Okay, I think I might have updated the 1.27 README to work in Leia, someone will have to trigger the test to run again, I don't have permission for that. |
* Attempt to repair the Leia test using another method
* Updated previous version tests to reflect Leia changes
Looks great thanks @lefte for fighting the good fight here! |
Bare minimum self-checks
main
Pieces of flare
Finally
If you have any issues or need help please join the
#contributors
channel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.