Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nginx:1.26 #55

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

todeveni
Copy link
Contributor

@todeveni todeveni commented May 27, 2024

Bare minimum self-checks

Fixes #49
Fixes #54

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for lando-nginx failed. Why did it fail? →

Name Link
🔨 Latest commit fe06011
🔍 Latest deploy log https://app.netlify.com/sites/lando-nginx/deploys/665f43efa17bdd00082a8aab

reynoldsalec
reynoldsalec previously approved these changes May 27, 2024
reynoldsalec
reynoldsalec previously approved these changes May 28, 2024
@reynoldsalec
Copy link
Member

@todeveni this looks good! Last thing it needs is to add your examples/1.26 into the .github/workflows/pr-nginx-tests.yml and then I think we're ready to rock.

@reynoldsalec reynoldsalec merged commit 04068ca into lando:main Jun 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx 1.26
2 participants