optimized for midcore

lando · Dec 7, 2024 · 428c72c · 428c72c
1 parent 4401b50
commit 428c72c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 6 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,23 +1,36 @@
 {
   "env": {
     "node": true,
-    "mocha": true
+    "mocha": true,
+    "es2021": true
   },
   "parser": "@babel/eslint-parser",
   "parserOptions": {
     "sourceType": "module",
     "ecmaVersion": 8,
     "requireConfigFile": false
   },
-  "extends": "google",
+  "extends": [
+    "eslint:recommended",
+    "google"
+  ],
   "rules": {
     "arrow-parens": ["error",
       "as-needed"
     ],
     "max-len": ["error", {
-      "code": 120,
+      "code": 140,
       "ignoreComments": true
     }],
+    "no-empty": ["error", {
+      "allowEmptyCatch": true
+    }],
+    "no-unused-vars": ["error", {
+      "vars": "all",
+      "args": "after-used",
+      "ignoreRestSiblings": false
+    }],
+
     "require-jsdoc": ["error", {
       "require": {
         "FunctionDeclaration": true,

diff --git a/.github/workflows/pr-nginx-tests.yml b/.github/workflows/pr-nginx-tests.yml
@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         lando-version:
-          - 3-edge-slim
+          - 3-edge
         os:
           - ubuntu-24.04
         node-version:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})
 
+* Optimized for `midcore`
+
 ## v1.4.3 - [December 6, 2024](https://github.com/lando/nginx/releases/tag/v1.4.3)
 
 * Updated the version index.md to get Docuverse page to build correctly.

diff --git a/builders/nginx.js b/builders/nginx.js
@@ -91,6 +91,6 @@ module.exports = {
 
       // Send it downstream
       super(id, options, {services: _.set({}, options.name, nginx)});
-    };
+    }
   },
 };
diff --git a/index.js b/index.js
@@ -1,3 +1,3 @@
 'use strict';
 
-module.exports = lando => {};
+module.exports = () => {};
diff --git a/tmpfile b/tmpfile
-Original file line number
+Diff line change
@@ Expand Up / @@ -91,6 +91,6 @@ module.exports = { @@
           // Send it downstream
           super(id, options, {services: _.set({}, options.name, nginx)});
-        };
+        }
       },
     };