Update default MariaDB version to 10.6, resolves lando/mariadb#25. #26
Conversation
👷 Deploy request for lando-mariadb pending review.Visit the deploys page to approve it
|
tormi
changed the title
tormi
force-pushed
the
feature/25-upgrade-default-mariadb
branch
from
e39aac7 to
ea83676
Compare
| @@ -7,9 +7,9 @@ const _ = require('lodash'); | |||
| module.exports = { | |||
| name: 'mariadb', | |||
| config: { | |||
| version: '10.3', | |||
| supported: ['10.6', '10.5', '10.4', '10.3', '10.2', '10.1'], | |||
There was a problem hiding this comment.
Existing versions should not be removed from the supported array. If you remove this, for people who use these versions, Lando will result to ERROR ==> mariadb version 10.2 is not supported.
There was a problem hiding this comment.
@kaszarobert Tormi put versions 10.3 and below into the legacy array, so it'd just flash a warning that users are on old versions.
There was a problem hiding this comment.
@reynoldsalec: We would want to keep 10.3 in the supported array and remove from the legacy array, right?
|
@kaszarobert I think the reason I didn't merge this back when @tormi suggested it was we were being hesitant about updating the I'm guessing that the update from 10.3 -> 10.6 doesn't introduce incompatibilities, if one of you could confirm that, we should definitely bump the default version. I think this is the big reason Pirog is probably going to dump default versioning in Lando 4. |
Resolves #25.