Refactor, update, and isolate. (#27)

* Refactor plugin structure, update to node 18, update dependencies, isolate testing.

* Feed the linter.

.github/workflows/pr-apache-tests.yml

@@ -19,7 +19,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -36,12 +36,9 @@ jobs:
         with:
           lando-version: ${{ matrix.lando-version }}
           config: |
-            plugins.@lando/apache=/home/runner/work/apache/apache
+            setup.skipCommonPlugins=true
+            setup.plugins.@lando/apache=/home/runner/work/apache/apache
           telemetry: false
-      - name: Verify Lando works and we are dogfooding this plugin for tests
-        run: |
-          lando version
-          lando config --path plugins | grep apache | grep /home/runner/work/apache/apache || (echo "::error:: Not dogfooding this plugin correctly!" && exit 1)
       - name: Run Leia Tests
         uses: lando/run-leia-action@v2
         with:

.github/workflows/pr-docs-tests.yml

@@ -11,7 +11,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
     steps:
       # Install deps and cache
       - name: Checkout code

.github/workflows/pr-linter.yml

@@ -11,7 +11,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
     steps:
       # Install deps and cache
       - name: Checkout code

.github/workflows/pr-unit-tests.yml

@@ -14,7 +14,7 @@ jobs:
           - ubuntu-22.04
           - macos-12
         node-version:
-          - '16'
+          - '18'
     steps:
       # Install deps and cache
       - name: Checkout code

.github/workflows/release.yml

@@ -17,7 +17,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
     steps:
       # Install deps and cache
       - name: Checkout code

.node-version

@@ -1 +1 @@
-16
+18

services/apache/builder.js → builders/apache.js

@@ -2,6 +2,7 @@
 
 // Modules
 const _ = require('lodash');
+const path = require('path');
 
 // Builder
 module.exports = {
@@ -13,7 +14,7 @@ module.exports = {
       '2.4': 'bitnami/apache:2.4.41-debian-10-r52',
     },
     patchesSupported: true,
-    confSrc: __dirname,
+    confSrc: path.resolve(__dirname, '..', 'config'),
     defaultFiles: {
       server: 'httpd.conf',
       vhosts: 'default.conf',
@@ -27,6 +28,7 @@ module.exports = {
   },
   parent: '_webserver',
   builder: (parent, config) => class LandoApache extends parent {
+    // Constructor
     constructor(id, options = {}) {
       options = _.merge({}, config, options);
       // Use different default for ssl

package.json

@@ -14,7 +14,7 @@
     "apache"
   ],
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
   "bundledDependencies": [
     "lodash"