Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL 8.0 warning due to empty password. #108

Merged
merged 2 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})

* Upgrading PHP from 8.2 to 8.3 which is the new default at Acquia.
* Upgrade @lando/mysql for better MySQL 8 support

## v1.3.1 - [September 12, 2024](https://github.com/lando/acquia/releases/tag/v1.3.1)

Expand Down
9 changes: 9 additions & 0 deletions examples/acquia-mysql-8/.lando.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: acquia-mysql-8
recipe: acquia
services:
database:
type: "mysql:8.0"

# do not remove this
plugins:
"@lando/acquia": ../..
40 changes: 40 additions & 0 deletions examples/acquia-mysql-8/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Acquia MySQL 8.0 Example

This example exists primarily to test the following documentation:

* [Acquia Recipe](https://docs.lando.dev/acquia/config.html)

Start up tests
--------------

Run the following commands to get up and running with this example.

```bash
# Should start up successfully
lando poweroff
lando start
```

Verification commands
---------------------

Run the following commands to validate things are rolling as they should.

```bash
# Should be running mysql 8.0 by default
lando mysql -V | grep 8.0

# Should be able to connect to the database with the default creds
lando mysql acquia -e quit
```

Destroy tests
-------------

Run the following commands to trash this app like nothing ever happened.

```bash
# Should be destroyed with success
lando destroy -y
lando poweroff
```
3 changes: 3 additions & 0 deletions examples/acquia-mysql-8/docroot/env.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to use these (and print('Hello Lando!'); in index.php) in tests in the README.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on env.php and site-environment.php. Those are extra. Keeping index.php for the docroot which is required.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<pre>
<?php
print_r($_ENV);
3 changes: 3 additions & 0 deletions examples/acquia-mysql-8/docroot/index.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

print('Hello Lando!');
3 changes: 3 additions & 0 deletions examples/acquia-mysql-8/docroot/site-environment.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

print($_ENV['AH_SITE_ENVIRONMENT']);
25 changes: 23 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading