Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds description for the form element manager to the documentation #196

Draft
wants to merge 6 commits into
base: 3.7.x
Choose a base branch
from
Draft

Adds description for the form element manager to the documentation #196

wants to merge 6 commits into from

Conversation

froschdesign
Copy link
Member

No description provided.

weierophinney
weierophinney requested changes Oct 26, 2022
View reviewed changes
docs/book/v3/form-element-manager.md Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
@froschdesign froschdesign marked this pull request as draft October 27, 2022 06:57
@Ocramius Ocramius added this to the 3.5.1 milestone Oct 27, 2022
@Ocramius Ocramius removed this from the 3.5.1 milestone Oct 29, 2022
@Ocramius Ocramius changed the base branch from 3.5.x to 3.7.x November 20, 2022 22:31
weierophinney
weierophinney requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided a number of suggested changes.

Additionally, I see a mixture of Oxford comma usage and non-Oxford comma usage; please standardize on one or the other (I'm not sure if we specify which style to use in the style guide...)

docs/book/v3/application-integration/form-element-manager-mvc.md Outdated Show resolved Hide resolved
docs/book/v3/application-integration/form-element-manager-mvc.md Outdated Show resolved Hide resolved
docs/book/v3/application-integration/form-element-manager-mvc.md Outdated Show resolved Hide resolved
docs/book/v3/application-integration/form-element-manager-mvc.md Outdated Show resolved Hide resolved
docs/book/v3/application-integration/form-element-manager-mvc.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
docs/book/v3/form-element-manager.md Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member Author

Additionally, I see a mixture of Oxford comma usage and non-Oxford comma usage; please standardize on one or the other (I'm not sure if we specify which style to use in the style guide...)

This topic is not yet covered in the guide. I will add a note for it.

@froschdesign froschdesign linked an issue Dec 21, 2022 that may be closed by this pull request
Documentation around FormElementManager->get() #36
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weierophinney weierophinney weierophinney requested changes

Assignees
No one assigned
Labels
Documentation Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation around FormElementManager->get()
3 participants
@froschdesign @weierophinney @Ocramius