Themes selector page #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying zed-themes with
|
| Latest commit: |
d72ae21
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab2c80f8.zed-themes.pages.dev |
| Branch Preview URL: | https://themes.zed-themes.pages.dev |
Also dropped navTo function in favour of anhors
|
@dfntlynotjorn Hey thanks for checking it preview, it is currently a bit borked. I am looking to use Remix with Vite and Cloudflare (based of this repo) to support KV data for hosting and sharing themes. Currently, it's working locally but deployed seems like Cloudflare routes is intercepting assets routes. I hoped to have this solved in next couple of days |
…use babel plugin transform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a page to browse all current themes and select them to edit or download.
Still opting to not add external libraries as we only have a few pages to handle and seems heavy-handed to add react-router just for that.
Also still staying with static site and loading json from public assets, we can make a CI action to fetch all the themes from the zed extension repo.
Preview: https://themes.zed-themes.pages.dev/