Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack Integration #36

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Slack Integration #36

wants to merge 54 commits into from

Conversation

timatron
Copy link
Contributor

@timatron timatron commented Jan 2, 2020 •
edited
Loading

This PR should be merged after #35

  • Added slack notifications and testing button
  • Separated notifications so they can be email, slack, or both
  • Reorganized settings page
  • Changed validation to not turn on notifications for email or slack unless required fields are valid
  • Test email or slack message are now triggered with a temporary transient
  • Removed javascript functions
  • Added descriptions to all functions

timatron and others added 30 commits December 27, 2019 19:28
@timatron
getting the settings setup
cfa9852
@timatron
stubbing out new variables needed
afbac51
@timatron
remove jquery depedancy
6c011ef
@timatron
reconfigured email settings
bdac4e7
@timatron
setup fields for slack
ddd8e4b
@timatron
turns out we dont need js anymore
f396a1c
@timatron
setting up slack notifications and test emails
ef4eec4
@timatron
testing triggers work now
7e4cfec
@timatron
cleanup
8f353f9
@timatron
making final notification work
21441ed
@timatron
everything works with slack
183a0db
@timatron
added name and url to message
71ea91f
@timatron
Merge pull request #7 from alleyinteractive/feature/TOOL-494/remove-e…
724d853 
…xternal-cron

Feature/tool 494/remove external cron
@timatron
s/bloginfo/homeurl/
28d96ea
@timatron
Merge pull request #9 from alleyinteractive/feature/TOOL-494/remove-e…
2541a23 
…xternal-cron

Feature/tool 494/remove external cron
@timatron
Merge branch 'master' into feature/TOOL-494/slack
d22952c
@timatron
phpcs and readme updates
66ebd66
@timatron
update description to include slack
b47922a
@timatron
bring back site name
69b3812
@timatron
turn on email updates by default if upgrading from an earlier version…
b289357 
… of the plugin
@timatron
simplicity as per @jomurgel
916dae2
@timatron @jomurgel
:baby-yoda:
d0c7c69 
Co-Authored-By: jomurgel <[email protected]>
@timatron @jomurgel
__ good catch @jomurgel
d343d36 
Co-Authored-By: jomurgel <[email protected]>
@timatron
escaping
01c47bd
@timatron
Merge branch 'feature/TOOL-494/slack' of https://github.com/alleyinte…
0737f34 
…ractive/wp-updates-notifier into feature/TOOL-494/slack
@timatron
escaping and translating
fd396c3
@timatron
no isset for get_transient as per @mslinnea
6f6e40e
@timatron
simplified email notifications check as per @mslinnea
c64b525
@timatron
lots of doc blocks as per @mslinnea
7ff51cd
@timatron
one more docblock
d72b022
@l3rady
Copy link
Owner

l3rady commented Jan 6, 2020

Some merge conflicts here. Can we clean up please? Cheers

@timatron
Copy link
Contributor Author

timatron commented Jan 6, 2020

@l3rady should be good to go now

@timatron
Copy link
Contributor Author

timatron commented Jan 6, 2020

i definitely plan on bulking out the filters and allowing overrides to the notification methods

timatron and others added 9 commits January 20, 2020 12:22
@timatron
cleaning up the email filters and adding slack filters
83b60eb
@timatron
updated documentation and added docblocks for filters
cc31b68
@timatron
Update class-sc-wp-updates-notifier.php
e68fa2f 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Update class-sc-wp-updates-notifier.php
740038e 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Update class-sc-wp-updates-notifier.php
a4ee7b3 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Update class-sc-wp-updates-notifier.php
c26edaf 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Update class-sc-wp-updates-notifier.php
8cabaab 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Update class-sc-wp-updates-notifier.php
136705c 
Co-Authored-By: Renato Alves <[email protected]>
@timatron
Merge pull request #10 from alleyinteractive/feature/TOOL-502/filters
ddedbf0 
cleaning up the email filters and adding slack filters
@timatron
Copy link
Contributor Author

@l3rady filters in for you with comments

l3rady
l3rady previously approved these changes Feb 27, 2020
View reviewed changes
@timatron
Copy link
Contributor Author

hey @l3rady this is ready to roll, sorry for some of the unsigned commits, can we turn that off for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3rady l3rady l3rady left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timatron @l3rady