syntax: properly configure syntax regions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically the `yagStr` region exhibits some odd behaviour (even more so in conjunction with jo3-l/yag-template-lsp) in which a newline-terminated double-quoted string extends its match region to EOF, when it should be EOL. Fix this problem by setting the `keepend` attribute on `yagExpr`, which disallows contained regions to go past their respective `end` pattern. This fixes the funky behaviour of `yagStr`, whilst having its respective tests still pass- As a side-effect, we have to set `yagNestedBrace` to `extend`, such that the second nested pair `}}` is highlighted as an error as well. For similar reasons, we must do the same for `yagRawStr`, as it could theoretically contain legally nested braces within the raw string, as exhibited by one of the test cases. Without these secondary changes, tests are failing. Signed-off-by: Luca Zeuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this pull request does and why it should be merged:
Specifically the
yagStrregion exhibits some odd behaviour (even more so inconjunction with jo3-l/yag-template-lsp) in which a newline-terminated
double-quoted string extends its match region to EOF, when it should be EOL.
Fix this problem by setting the
keependattribute onyagExpr, whichdisallows contained regions to go past their respective
endpattern. Thisfixes the funky behaviour of
yagStr, whilst having its respective tests stillpass-
As a side-effect, we have to set
yagNestedBracetoextend, such that thesecond nested pair
}}is highlighted as an error as well. For similar reasons,we must do the same for
yagRawStr, as it could theoretically contain legallynested braces within the raw string, as exhibited by one of the test cases.
Without these secondary changes, tests are failing.
Signed-off-by: Luca Zeuch [email protected]
Terms