Merge pull request #13 from Ericarman/bug/memeory-leak-fix

Fix memory leak on webView subscribe
kylehickinson · Dec 31, 2024 · 8abc88c · 8abc88c
2 parents b500add + fd42466
commit 8abc88c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/WebView/WebView.swift b/Sources/WebView/WebView.swift
@@ -17,9 +17,11 @@ public class WebViewStore: ObservableObject {
 
   private func setupObservers() {
     func subscriber<Value>(for keyPath: KeyPath<WKWebView, Value>) -> NSKeyValueObservation {
-      return webView.observe(keyPath, options: [.prior]) { _, change in
+      return webView.observe(keyPath, options: [.prior]) { [weak self] _, change in
+        guard let self else { return }
+
         if change.isPrior {
-          self.objectWillChange.send()
+          objectWillChange.send()
         }
       }
     }