Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glob ** not globbing subdirectories #89

Closed
wants to merge 1 commit into from
Closed

Fix glob ** not globbing subdirectories #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/PathKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ extension Path {
free(cPattern)
}

let flags = GLOB_TILDE | GLOB_BRACE | GLOB_MARK
let flags = GLOB_TILDE | GLOB_BRACE | GLOB_MARK | GLOB_NOESCAPE
if system_glob(cPattern, flags, nil, &gt) == 0 {
#if os(Linux)
let matchc = gt.gl_pathc
Expand Down
5 changes: 5 additions & 0 deletions Tests/PathKitTests/PathKitSpec.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,11 @@ describe("PathKit") {
let results = try (fixtures + "permissions").children().map { $0.absolute() }.sorted(by: <)
try expect(paths) == results.sorted(by: <)
}

$0.it("can glob nested directories using **") {
let paths = fixtures.glob("**/child")
try expect(paths) == [fixtures + "directory/subdirectory/child", fixtures + "directory/child"]
}
}

$0.describe("#match") {
Expand Down