Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return opaque iterator for nearest neighbor searches #98

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylebarron
Copy link
Owner

@kylebarron kylebarron commented Jan 6, 2025

It would be nice to finish this but also ensure this isn't a performance regression. It feels like the iterator has to repeat some steps that the existing method doesn't.

Perhaps it would be better to introduce a state machine, so that the iterator can check between an enum of states like "search child nodes, search queue, etc".

But overall I want to get the main library released, so this will wait for the next version.

@kylebarron kylebarron marked this pull request as draft January 6, 2025 16:59
@kylebarron
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant