Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Makefile for Unlink error #662

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Flying-Tom
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

PACKAGE_SHIM in Makefile is a directory and .INTERMEDIATE rm cannot handle it.

ref: kyverno/Makefile

Which issue(s) this PR fixes:
Fixes #661

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit e96975b
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/66afa8f71d61f90008d60bd2

Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
@LiZhenCheng9527
Copy link
Contributor

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 7e8981a into kurator-dev:main Aug 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make: unlink: /home/lu/go/kurator/.gopath/src/kurator.dev: is a directory
4 participants