add attachedcluater e2e test #594
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
LiZhenCheng9527
force-pushed
the
e2e
branch
8 times, most recently
from
02be637 to
ccad971
Compare
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
|
@hzxuzhonghu This PR is ready for review. |
hack/e2e-test/install.sh
Outdated
| KUBECONFIG_PATH=${KUBECONFIG_PATH:-"${HOME}/.kube"} | ||
| MAIN_KUBECONFIG=${MAIN_KUBECONFIG:-"${KUBECONFIG_PATH}/kurator-host.config"} | ||
| export KUBECONFIG=${MAIN_KUBECONFIG} | ||
| VERSION=${VERSION:-"0.95.27"} |
There was a problem hiding this comment.
Please change to using the commit id
| REPO_ROOT=$(git rev-parse --show-toplevel) | ||
| DIR="$(cd "$(dirname "$0")" && pwd)" | ||
|
|
||
| "$DIR"/attachedcluster.sh |
There was a problem hiding this comment.
We can use go code to write it
|
You can see the details of the e2e test in the CI of this PR. |
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
e2e/attachedcluster_test.go
Outdated
| ) | ||
|
|
||
| ginkgo.BeforeEach(func() { | ||
| namespace = "default" |
There was a problem hiding this comment.
nit: use a random namespace for each test
| }, | ||
| } | ||
| fleet := resources.NewFleet(namespace, fleetname, clusters) | ||
| fleetCreateErr := resources.CreateFleet(kuratorClient, fleet) |
There was a problem hiding this comment.
don't we need to check fleet status?
| clusterv1a1 "kurator.dev/kurator/pkg/apis/cluster/v1alpha1" | ||
| ) | ||
|
|
||
| var _ = ginkgo.Describe("[AttachedClusters] AttachedClusters testing", func() { |
There was a problem hiding this comment.
we need to cleanup the resources created per test
Signed-off-by: LiZhenCheng9527 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
add attachedcluater e2e test
Which issue(s) this PR fixes:
a part of #436