delete github.com/mitchellh/cli in pkg/generic #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hzxuzhonghu
approved these changes
Nov 23, 2023
hzxuzhonghu
reviewed
Nov 23, 2023
go.mod
Outdated
| @@ -225,6 +222,7 @@ require ( | |||
| github.com/mattn/go-isatty v0.0.17 // indirect | |||
| github.com/mattn/go-runewidth v0.0.13 // indirect | |||
| github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect | |||
| github.com/mitchellh/cli v1.1.3 // indirect | |||
There was a problem hiding this comment.
Is it still indirect imported
LiZhenCheng9527
force-pushed
the
delete-generic-cli
branch
from
2139f36 to
a530416
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LiZhenCheng9527
force-pushed
the
delete-generic-cli
branch
from
a530416 to
fbaf83c
Compare
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: LiZhenCheng9527 <[email protected]>
LiZhenCheng9527
force-pushed
the
delete-generic-cli
branch
from
fbaf83c to
944b88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Remove github.com/mitchellh/cli in generic to handle lisence problem.
Which issue(s) this PR fixes:
Fixes # #468