Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED FLY FIGHTER GAME #4773

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheNikhilRaj
Copy link

@TheNikhilRaj TheNikhilRaj commented Jul 8, 2024

PR Description 📜

I created a simple game Fly Fighter building with JS.

Description
Overview : This is a very interesting and innovative , the users are gonna love this game.

Fixes # #4771


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

346280545-e9529581-9d3e-4494-8eea-1b0a342de5cb



@kunjgit task completed!

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 8, 2024

Thank you @TheNikhilRaj ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! you need to make following changes
Add your game entry in the main Readme.md file of the gamezone refer other entries there for the format
Add your game image in the asset folder of the gamezone follow contribution guidelines while naming the image

@kunjgit kunjgit mentioned this pull request Jul 15, 2024
10 tasks
@TheNikhilRaj TheNikhilRaj requested a review from ishita-43 July 15, 2024 20:06
@TheNikhilRaj
Copy link
Author

TheNikhilRaj commented Jul 15, 2024

@kunjgit @ishita-43 as you had said i updated the following changes.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes
add your game entry in main readme.md file of the repo by editing it
add your game image in the asset folder of the gamezone follow naming convention while naming the image

@ishita-43
Copy link
Collaborator

@kunjgit @ishita-43 as you had said i updated the following changes.

you will find the readme file in the gamezone repo along with asset folder and games folder

@TheNikhilRaj
Copy link
Author

Please make the following changes
add your game entry in main readme.md file of the repo by editing it
add your game image in the asset folder of the gamezone follow naming convention while naming the image

@ishita-43 But I have done these things, please you can check it once.

@TheNikhilRaj
Copy link
Author

@kunjgit @ishita-43 as you had said i updated the following changes.

you will find the readme file in the gamezone repo along with asset folder and games folder

It's already done. @ishita-43

@ishita-43
Copy link
Collaborator

@kunjgit @ishita-43 as you had said i updated the following changes.

you will find the readme file in the gamezone repo along with asset folder and games folder

It's already done. @ishita-43

you are saying that your game exists in below file https://github.com/kunjgit/GameZone/blob/main/README.md

@kunjgit kunjgit mentioned this pull request Jul 19, 2024
10 tasks
@TheNikhilRaj
Copy link
Author

TheNikhilRaj commented Jul 19, 2024

@kunjgit @ishita-43 as you had said i updated the following changes.

you will find the readme file in the gamezone repo along with asset folder and games folder

It's already done. @ishita-43

you are saying that your game exists in below file https://github.com/kunjgit/GameZone/blob/main/README.md

@ishita-43 yes i have added my game many times in this file https://github.com/kunjgit/GameZone/blob/main/README.md

please do some help from your side i don't what is going in this repo because i have added with the guidelines and added in the readme file please do it from your side. @ishita-43

@TheNikhilRaj TheNikhilRaj requested a review from ishita-43 July 19, 2024 12:33
@ishita-43
Copy link
Collaborator

The thing is you need to add your game in main readme file and make changes in this pr only as only one pr is allowed is allowed in this repository so make sure that you make your changes in this pr only by updating your pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants