Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): add all valid resources and skip only not valid #12776

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Feb 7, 2025

Motivation

While working on kumahq/kuma#12719, I noticed some strange behavior. If there are X resources and one is invalid, none of the valid resources are added. Once the invalid resource is fixed, the previously valid resources are still not added.

We send a NACK for the invalid resource type, but there's no way to reject only a single resource of that type—we have to NACK the entire resource type. Additionally, since the hash in the cache remains unchanged for valid resources, they are not resent (this is how Delta xDS works).

TBA

Implementation information

Supporting documentation

Fix #XX

@lukidzi lukidzi added ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) backport labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant