chore(build): publish no release images with -dev suffix

[lukidzi]

Motivation

We want to separate release images from the ones that we build.

Implementation

When the version has preview scripts add a suffix dev to the repository

example:
when tag: kuma-dp, kuma-init, kuma-cp, kumactl, kuma-dni
other: kuma-dp-dev, kuma-init-dev, kuma-cp-dev, kumactl-dev, kuma-cni-dev

fix: #12508

[github-actions]

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

• Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
• PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
• This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
• IPv6 is taken into account (.e.g: no string concatenation of host port)
• Tests (Unit test, E2E tests, manual test on universal and k8s)
  • Don't forget ci/ labels to run additional/fewer tests
• Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
• Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

[lahabana]

Can't be actually just do:

$(DOCKER_REGISTRY)/$(if $(2),$(2)-)$(1)$(if $(DOCKER_DEV_IMAGE_SUFFIX),-$(DOCKER_DEV_IMAGES_SUFFIX)):$(BUILD_INFO_VERSION)

Seems like it's equivalent and more readable to me no?

[lahabana]

Also any specific rational for prefix vs suffix?

[lukidzi]

I feel suffix is more used in different repos:
https://hub.docker.com/r/kong/kong-gateway-dev
https://hub.docker.com/r/kong/kong-dev
https://hub.docker.com/r/envoyproxy/envoy-dev

[lahabana]

Actually there's been further thinking around this and we're looking at using a different registry for non released images.

I think that for Kuma it'll likely be GHCR. This is TBD but I'd close this until we make a decision

[lahabana]

Why the indirection? Feels like we could use IMAGE_REPOSITORY_SUFFIX directly in the script no?

[lahabana]

Also any specific rational for prefix vs suffix?

[lukidzi]

Actually there's been further thinking around this and we're looking at using a different registry for non released images.

I think that for Kuma it'll likely be GHCR. This is TBD but I'd close this until we make a decision

Ok, I can close it for now, and once we agree we can reopen with the provided review suggestions