Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XML headers to track Mac::PropertyList #11

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

trwyant
Copy link
Contributor

@trwyant trwyant commented Jan 9, 2025

This pull request addresses RT 156143 by bumping the Mac::PropertyList dependency to 1.601 (which introduced the change in the XML header) and changing all the tests to use the new header.

@trwyant
Copy link
Contributor Author

trwyant commented Jan 11, 2025

The original commit in the pull request forgot to update the required version of Mac::PropertyList in META.*. This was fixed by a new commit.

@kulp
Copy link
Owner

kulp commented Jan 14, 2025

Hello @trwyant, thanks for this PR.

This pull request addresses RT 156143

Can you link to that bug for my information? I have not used RT in a long time, and that number appears not to be in the static archive I found (https://rt-cpan.github.io/Public/Bug/Display/156143/ does not work, though https://rt-cpan.github.io/Public/Bug/Display/63066/ does).

I notice the 5.10 failure on macOS in CI, but I have not yet looked into the reasons for it.

@trwyant
Copy link
Contributor Author

trwyant commented Jan 15, 2025

Here is the RT Ticket. I noted the Perl 5.10 failures too, but only glanced at them. It passes with 5.10.1 on my box, or at least it did after I upgraded Mac::PropertyList.

@kulp
Copy link
Owner

kulp commented Jan 15, 2025

Thanks. I do not know why I was having trouble with RT earlier.

I will apply make some final checks soon and likely merge this in a day or two. Thanks again.

@kulp kulp merged commit b5720c2 into kulp:master Jan 18, 2025
2 of 4 checks passed
kulp added a commit to kulp/Mac-PropertyList-XS that referenced this pull request Jan 20, 2025
kulp added a commit to kulp/Mac-PropertyList-XS that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants