Fixes gin-mode issue, removes panic(err) from public-facing code paths (

#110)

Tiltfile

@@ -73,11 +73,11 @@ k8s_resource(
   'kubetail-server',
   port_forwards='4000:4000',
   objects=[
-    'kubetail-server:serviceaccount',
     'kubetail-server:clusterrole',
     'kubetail-server:clusterrolebinding',
     'kubetail-server:role',
     'kubetail-server:rolebinding',
+    'kubetail-server:serviceaccount',
   ],
   resource_deps=['kubetail-shared'],
 )

backend/agent/internal/services/logmetadata/logmetadata.go

@@ -203,7 +203,7 @@ func (s *LogMetadataService) newK8SClientset(ctx context.Context) kubernetes.Int
 
 	clientset, err := kubernetes.NewForConfig(cfg)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	return clientset

backend/common/config/config.go

@@ -54,7 +54,7 @@ type Config struct {
 	Server struct {
 		Addr     string `validate:"omitempty,hostname_port"`
 		BasePath string `mapstructure:"base-path"`
-		GinMode  string `validate:"omitempty,oneof=debug release"`
+		GinMode  string `mapstructure:"gin-mode" validate:"omitempty,oneof=debug release"`
 
 		// session options
 		Session struct {

backend/common/k8shelpers/k8shelpers.go

@@ -20,6 +20,7 @@ import (
 	"os"
 	"regexp"
 
+	zlog "github.com/rs/zerolog/log"
 	authv1 "k8s.io/api/authentication/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -39,7 +40,7 @@ type Options struct {
 func MustConfigure(cfg *config.Config) *rest.Config {
 	k8sCfg, err := Configure(cfg)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 	return k8sCfg
 }
@@ -58,7 +59,7 @@ func Configure(cfg *config.Config) (*rest.Config, error) {
 		}
 		return configureLocal(cfg.KubeConfig)
 	default:
-		panic(errors.New("not implemented"))
+		panic("not implemented")
 	}
 }
 
@@ -125,7 +126,7 @@ func (s *HelperService) HasAccess(token string) (string, error) {
 
 		return getUsername(result.Status.User.Username), nil
 	default:
-		panic(errors.New("not implemented"))
+		panic("not implemented")
 	}
 }
 

backend/server/cmd/main.go

@@ -2,13 +2,15 @@ package main
 
 import (
 	"context"
+	"fmt"
 	"net/http"
 	"os"
 	"os/signal"
 	"strings"
 	"syscall"
 	"time"
 
+	"github.com/gin-gonic/gin"
 	"github.com/go-playground/validator/v10"
 	zlog "github.com/rs/zerolog/log"
 	"github.com/spf13/cobra"
@@ -21,7 +23,7 @@ import (
 type CLI struct {
 	Addr    string `validate:"omitempty,hostname_port"`
 	Config  string `validate:"omitempty,file"`
-	GinMode string `validate:"omitempty,oneof=debug release"`
+	GinMode string `validate:"omitempty,oneof=release debug"`
 }
 
 func main() {
@@ -61,6 +63,11 @@ func main() {
 				zlog.Fatal().Caller().Err(err).Send()
 			}
 
+			// set gin mode
+			fmt.Println(v.GetString("server.gin-mode"))
+			fmt.Println(cfg.Server.GinMode)
+			gin.SetMode(cfg.Server.GinMode)
+
 			// configure logger
 			config.ConfigureLogger(config.LoggerOptions{
 				Enabled: cfg.Server.Logging.Enabled,

backend/server/graph/helpers.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"encoding/base64"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"sort"
@@ -29,6 +28,7 @@ import (
 	"time"
 
 	"github.com/99designs/gqlgen/graphql/handler/transport"
+	zlog "github.com/rs/zerolog/log"
 	"github.com/sosodev/duration"
 	appsv1 "k8s.io/api/apps/v1"
 	batchv1 "k8s.io/api/batch/v1"
@@ -613,12 +613,12 @@ func newLogRecordFromLogLine(logLine string) model.LogRecord {
 
 	parts := strings.SplitN(logLine, " ", 2)
 	if len(parts) != 2 {
-		panic(errors.New("log line timestamp not found"))
+		panic("log line timestamp not found")
 	}
 
 	ts, err := time.Parse(time.RFC3339Nano, parts[0])
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	return model.LogRecord{
@@ -645,7 +645,7 @@ func decodeTailCursor(input string) (*TailCursor, error) {
 	}
 	cursor := &TailCursor{}
 	if err = json.Unmarshal(decodedData, cursor); err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 	return cursor, nil
 }

backend/server/graph/model/models_custom.go

@@ -21,6 +21,7 @@ import (
 	"time"
 
 	"github.com/99designs/gqlgen/graphql"
+	zlog "github.com/rs/zerolog/log"
 	"google.golang.org/protobuf/types/known/timestamppb"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
@@ -51,7 +52,7 @@ func MarshalStringMap(val map[string]string) graphql.Marshaler {
 	return graphql.WriterFunc(func(w io.Writer) {
 		err := json.NewEncoder(w).Encode(val)
 		if err != nil {
-			panic(err)
+			zlog.Fatal().Err(err).Send()
 		}
 	})
 }

backend/server/graph/resolver.go

@@ -18,13 +18,15 @@ import (
 	"context"
 	"slices"
 
-	grpcdispatcher "github.com/kubetail-org/grpc-dispatcher-go"
+	zlog "github.com/rs/zerolog/log"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/dynamic"
 	dynamicFake "k8s.io/client-go/dynamic/fake"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/rest"
+
+	grpcdispatcher "github.com/kubetail-org/grpc-dispatcher-go"
 )
 
 // This file will not be regenerated automatically.
@@ -58,7 +60,7 @@ func (r *Resolver) K8SClientset(ctx context.Context) kubernetes.Interface {
 
 	clientset, err := kubernetes.NewForConfig(cfg)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	return clientset
@@ -81,7 +83,7 @@ func (r *Resolver) K8SDynamicClient(ctx context.Context) dynamic.Interface {
 
 	dynamicClient, err := dynamic.NewForConfig(cfg)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	return dynamicClient

backend/server/internal/ginapp/auth.go

@@ -15,7 +15,6 @@
 package ginapp
 
 import (
-	"errors"
 	"net/http"
 	"time"
 
@@ -108,7 +107,7 @@ func (app *AuthHandlers) SessionGET(c *gin.Context) {
 			response["user"] = nil
 		}
 	default:
-		panic(errors.New("not implemented"))
+		panic("not implemented")
 	}
 
 	c.JSON(http.StatusOK, response)

backend/server/internal/ginapp/ginapp.go

@@ -30,6 +30,7 @@ import (
 	"github.com/gorilla/csrf"
 	adapter "github.com/gwatts/gin-adapter"
 	grpcdispatcher "github.com/kubetail-org/grpc-dispatcher-go"
+	zlog "github.com/rs/zerolog/log"
 	"k8s.io/client-go/rest"
 
 	"github.com/kubetail-org/kubetail/backend/common/config"
@@ -101,7 +102,7 @@ func NewGinApp(cfg *config.Config) (*GinApp, error) {
 		// set basepath to cwd
 		basepathTmp, err := os.Getwd()
 		if err != nil {
-			panic(err)
+			zlog.Fatal().Err(err).Send()
 		}
 		basepath = basepathTmp
 	}

backend/server/internal/ginapp/graphql.go

@@ -22,6 +22,7 @@ import (
 
 	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/gin-gonic/gin"
+	zlog "github.com/rs/zerolog/log"
 	"k8s.io/client-go/rest"
 
 	grpcdispatcher "github.com/kubetail-org/grpc-dispatcher-go"
@@ -41,7 +42,7 @@ func (app *GraphQLHandlers) EndpointHandler(cfg *rest.Config, grpcDispatcher *gr
 	// init resolver
 	r, err := graph.NewResolver(cfg, grpcDispatcher, allowedNamespaces)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	csrfTestServer := http.NewServeMux()

backend/server/internal/ginapp/helpers.go

@@ -58,7 +58,7 @@ func mustLoadTemplatesWithFuncs(glob string) *template.Template {
 	// parse templates from a specified directory or pattern
 	parsedTemplates, err := tmpl.ParseGlob(glob)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	return parsedTemplates

backend/server/internal/ginapp/website.go

@@ -22,6 +22,7 @@ import (
 	"path"
 
 	"github.com/gin-gonic/gin"
+	zlog "github.com/rs/zerolog/log"
 
 	"github.com/kubetail-org/kubetail/backend/common/config"
 )
@@ -54,7 +55,7 @@ func (app *WebsiteHandlers) EndpointHandler(cfg *config.Config) gin.HandlerFunc
 	decoder := json.NewDecoder(manifestFile)
 	err = decoder.Decode(&manifest)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 
 	// define runtime config for react app
@@ -64,7 +65,7 @@ func (app *WebsiteHandlers) EndpointHandler(cfg *config.Config) gin.HandlerFunc
 
 	runtimeConfigBytes, err := json.Marshal(runtimeConfig)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 	runtimeConfigJS := template.JS(string(runtimeConfigBytes))
 

backend/server/internal/k8shelpers/k8shelpers.go

@@ -20,6 +20,7 @@ import (
 	"os"
 	"regexp"
 
+	zlog "github.com/rs/zerolog/log"
 	authv1 "k8s.io/api/authentication/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -45,7 +46,7 @@ type Options struct {
 func MustConfigure(opts Options) *rest.Config {
 	cfg, err := configure(opts)
 	if err != nil {
-		panic(err)
+		zlog.Fatal().Err(err).Send()
 	}
 	return cfg
 }
@@ -64,7 +65,7 @@ func configure(opts Options) (*rest.Config, error) {
 		}
 		return configureLocal(opts.KubeConfig)
 	default:
-		panic(errors.New("not implemented"))
+		panic("not implemented")
 	}
 }
 
@@ -131,7 +132,7 @@ func (s *K8sHelperService) HasAccess(token string) (string, error) {
 
 		return getUsername(result.Status.User.Username), nil
 	default:
-		panic(errors.New("not implemented"))
+		panic("not implemented")
 	}
 }
 

hack/tilt/kubetail.yaml

@@ -11,8 +11,8 @@ data:
     allowed-namespaces: []
     server:
       addr: :4000
-      gin-mode: debug
       base-path: /
+      gin-mode: debug
       session:
         secret: REPLACEME
         cookie:
@@ -183,6 +183,22 @@ spec:
         configMap:
           name: kubetail
 ---
+kind: Service
+apiVersion: v1
+metadata:
+  name: kubetail-server
+  namespace: default
+spec:
+  selector:
+    app.kubernetes.io/name: kubetail
+    app.kubernetes.io/component: server
+  ports:
+  - name: http
+    protocol: TCP
+    port: 4000
+    targetPort: http
+    appProtocol: http
+---
 kind: ServiceAccount
 apiVersion: v1
 metadata: