Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #2015

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Replace deprecated command with environment file #2015

merged 1 commit into from
Oct 21, 2023

Conversation

jongwooo
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update .github/workflows/release.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/}

TO-BE

run: echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT

Which issue(s) this PR fixes:

Fixes #2014

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@pixiake
Copy link
Collaborator

pixiake commented Oct 21, 2023

@jongwooo Thanks for this contribution !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ec80fbcfabf488e850402feebe6ec1bb2b8aed24

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2023
@ks-ci-bot ks-ci-bot merged commit 9f05c61 into kubesphere:master Oct 21, 2023
3 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch October 21, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants